Fix for image assets that don't have set dimensions
What was the issue?
The remaining code from PHP 7 was causing that unsupported asset formats were causing errors when trying to open them in admin GUI. It is because in PHP 7 there was no need for null check variables.
How did you solve it?
I needed to add one if condition that checks if the value is set and if it is, return that value.
Why is this fix important?
There is now no error in admin GUI when trying to open assets that are not supported for preview.
What do you think about the current direction of the development of the entire Pimcore platform?
I love how open they are. They let people help in the development of Pimcore. No matter how impactful the bug or the new feature is, they talk with you and let you finish what you started. I sometimes felt like they could fix an issue in no time and they would rather talk with you and help you understand what should be done.
It’s great not only because that encourages people to continue to provide pull requests but also because they help you grow as a developer.
And if you want to check out this particular pull request, just follow the link!